Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Spotbugs unit test error with new html2text version #10003

Conversation

cneill
Copy link
Contributor

@cneill cneill commented Apr 22, 2024

Description

The PR #9990 to upgrade html2text hit a unit test failure due to a whitespace issue. This should resolve it so we can merge the html2text upgrade PR.

Test results

Spotbugs test that was failing now passes:

System check identified no issues (0 silenced).
test_description (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_description) ... ok
test_file (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_file) ... ok
test_find_file_path (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_find_file_path) ... ok
test_find_sast_source_line (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_find_sast_source_line) ... ok
test_find_sast_source_path (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_find_sast_source_path) ... ok
test_find_source_line (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_find_source_line) ... ok
test_mitigation (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_mitigation) ... ok
test_no_findings (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_no_findings) ... ok
test_parse_many_finding (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_parse_many_finding) ... ok
test_references (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_references) ... ok
test_version_4_4 (unittests.tools.test_spotbugs_parser.TestSpotbugsParser.test_version_4_4)
There was a big difference between version < 4.4.x and after ... ok

----------------------------------------------------------------------
Ran 11 tests in 0.182s

OK

Copy link

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
AppSec Analyzer (beta) 0 findings
Secrets Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@cneill cneill merged commit 1acad15 into DefectDojo:dependabot/pip/dev/html2text-2024.2.26 Apr 22, 2024
7 checks passed
mtesauro pushed a commit that referenced this pull request Apr 23, 2024
* Bump html2text from 2020.1.16 to 2024.2.26

Bumps [html2text](https://github.com/Alir3z4/html2text) from 2020.1.16 to 2024.2.26.
- [Release notes](https://github.com/Alir3z4/html2text/releases)
- [Changelog](https://github.com/Alir3z4/html2text/blob/master/ChangeLog.rst)
- [Commits](Alir3z4/html2text@2020.1.16...2024.2.26)

---
updated-dependencies:
- dependency-name: html2text
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixing Spotbugs unit test error with new html2text version (#10003)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
hblankenship pushed a commit to hblankenship/django-DefectDojo that referenced this pull request Apr 26, 2024
* Bump html2text from 2020.1.16 to 2024.2.26

Bumps [html2text](https://github.com/Alir3z4/html2text) from 2020.1.16 to 2024.2.26.
- [Release notes](https://github.com/Alir3z4/html2text/releases)
- [Changelog](https://github.com/Alir3z4/html2text/blob/master/ChangeLog.rst)
- [Commits](Alir3z4/html2text@2020.1.16...2024.2.26)

---
updated-dependencies:
- dependency-name: html2text
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixing Spotbugs unit test error with new html2text version (DefectDojo#10003)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant