Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior param #5

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Add behavior param #5

merged 6 commits into from
Aug 20, 2024

Conversation

edwardrf
Copy link
Contributor

@edwardrf edwardrf commented Aug 20, 2024

action.yaml Outdated Show resolved Hide resolved
@edwardrf edwardrf force-pushed the edw-add-behavior branch 2 times, most recently from c80cead to 49d38fa Compare August 20, 2024 17:08
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoring errors will affect all our 1-click deploys

@@ -24,14 +24,28 @@ jobs:

- name: Deploy
uses: ./
continue-on-error: true # Ignore dry run error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to merge this

Copy link
Member

@lionello lionello Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, better to leave the defang compose config and avoid adding the --behavior param

@lionello lionello merged commit 77495c4 into main Aug 20, 2024
1 check passed
@lionello lionello deleted the edw-add-behavior branch August 20, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants