add yolox implement #418
Merged
add yolox implement #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM~ |
DefTruth
requested changes
Jul 24, 2024
lite/trt/cv/trt_yolox.cpp
Outdated
| if (count > max_nms) | ||
| break; | ||
| } | ||
| #if LITEORT_DEBUG |
lite/trt/cv/trt_yolox.cpp
Outdated
| normalized(mat_rs,mean_vals,scale_vals); | ||
|
|
||
| //1. make the input | ||
| auto input = trtcv::utils::transform::create_tensor(mat_rs,input_node_dims,trtcv::utils::transform::CHW); |
There was a problem hiding this comment.
input是从函数内部返回的被new的指针，这种处理方式有很大内存泄漏的风险。建议把new float[]类似的操作替换成vector<float, elem_num>，通过使用引用或者vector的指针进行处理，如果需要拷贝数据，使用vector.data()获取数据指针以及vector.size()获取长度信息
There was a problem hiding this comment.
好的大佬@DefTruth
|
大佬已经修改完成@DefTruth |
DefTruth
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.