test: increase coverage #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
james-deepsource
commented
Mar 3, 2022
•
james-deepsource
commented
- Increase test coverage.
- Add jest-websocket-mock lib.
- Enable test-coverage analyzer.
james-deepsource
force-pushed
the
update-test-suite
branch
2 times, most recently
from
6be6479 to
73a1503
Compare
|
@yash-deepsource, I've added unit tests for the file sources. Testing |
james-deepsource
force-pushed
the
update-test-suite
branch
from
73a1503 to
728b4fc
Compare
james-deepsource
force-pushed
the
update-test-suite
branch
from
728b4fc to
eb81e06
Compare
update test descriptions
update test patterns
There was a problem hiding this comment.
Setup the test coverage analyzer as well w/ this PR? You will have to use the DS CLI to report the test coverage information back to DS. Ref: https://deepsource.io/docs/analyzer/test-coverage#javascript
Test code LGTM!
set cobertura as the coverage reporter
james-deepsource
force-pushed
the
update-test-suite
branch
12 times, most recently
from
04d527d to
5ec9728
Compare
james-deepsource
force-pushed
the
update-test-suite
branch
2 times, most recently
from
02cbfa4 to
f617554
Compare
leverage jest-websocket-mock
james-deepsource
force-pushed
the
update-test-suite
branch
from
f617554 to
92d84c7
Compare
james-deepsource
changed the title
WS instance
|
@yash-deepsource PTAL |
yash-deepsource
approved these changes
Mar 9, 2022
james-deepsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.