Skip to content

Conversation

taddyb
Copy link
Contributor

@taddyb taddyb commented Feb 21, 2025

Added:

This is mostly code-driven, and is a different type of blog than what has already been published

Copy link
Contributor

@jmframe jmframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into some errors:

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Cell In[3], [line 2](vscode-notebook-cell:?execution_count=3&line=2)
      [1](vscode-notebook-cell:?execution_count=3&line=1) file_pattern = f"s3://noaa-nwm-pds/nwm.{date}/{forecast_type}/nwm.{initial_time}.{forecast_type}.{variable}.*.nc"
----> [2](vscode-notebook-cell:?execution_count=3&line=2) noaa_files = fs.glob(file_pattern)
      [3](vscode-notebook-cell:?execution_count=3&line=3) noaa_files = sorted(["s3://" + f for f in noaa_files])
      [5](vscode-notebook-cell:?execution_count=3&line=5) so = dict(anon=True, default_fill_cache=False, default_cache_type="none")

NameError: name 'fs' is not defined

Need something like this:

# Define the S3 filesystem
fs = fsspec.filesystem("s3", anon=True)

Other than that, I think this really needs to end with a plot, either a spatial plot, a time series, or both!

@taddyb taddyb requested a review from jmframe May 17, 2025 18:51
@taddyb
Copy link
Contributor Author

taddyb commented May 17, 2025

Addressed the changes! Finally got around to this

@taddyb taddyb merged commit 67be2a5 into DeepGroundwater:master Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants