Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take advantage of absolute position packets #55

Closed
brunchboy opened this issue Aug 14, 2022 · 0 comments
Closed

Take advantage of absolute position packets #55

brunchboy opened this issue Aug 14, 2022 · 0 comments
Assignees
@brunchboy
Labels
enhancement

Comments

@brunchboy
Copy link
Member

CDJ-3000s send a new packet type that will allow us to do a vastly better job of tracking current player position and offering tight timecode integration. Once we can get our hands on one of these players, we’ll be able to implement and test this.
brunchboy added a commit that referenced this issue Oct 7, 2023
@brunchboy
Initial pass at precise position, #55
8854123 
It seems to be basically working, I can now see movement within
beats, even when the player is stopped. There are some glitches
around beat packets that need to be investigated.
@brunchboy brunchboy self-assigned this Oct 7, 2023
brunchboy added a commit that referenced this issue Oct 7, 2023
@brunchboy
Restore update processing for older players, #55
873c6d1 
My code that was supposed to ignore CDJ status packets when we have
seen precise position packets was broken if we had not yet received
any status packets.
brunchboy added a commit that referenced this issue Oct 7, 2023
@brunchboy
Fix implementation of tempo in position packets, #55
a2ed879 
These work backwards from other status packets.
brunchboy added a commit that referenced this issue Oct 7, 2023
@brunchboy
Fix interpretation of negative effective BPM, #55
604ea70
brunchboy added a commit that referenced this issue Oct 8, 2023
@brunchboy
Handle out-of-order beat packet, #55
b05cac3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunchboy brunchboy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunchboy