Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulating phrase messages is problematic #160

Closed
brunchboy opened this issue Mar 15, 2023 · 1 comment
Closed

Simulating phrase messages is problematic #160

brunchboy opened this issue Mar 15, 2023 · 1 comment
Labels

Comments

@brunchboy
Copy link
Member

Describe the bug
The context in which phrase expressions are simulated is missing actual phrase context in the runtime information, which tends to lead to NullPointerExceptions.

To Reproduce
Set up a phrase cue with a beat expression like:

(timbre/info "phrase beat ran, phrase-type:" phrase-type)
(when midi-output
  (midi/midi-note-on midi-output 0x10 (phrase-velocities phrase-type) (dec device-number)))

When you try to simulate it, you will find that phrase-type is nil, which crashes midi-note-on.

Options
It seems we can either send in a modified version of the show where there seems to be a track with phrase analysis playing, or at least enough of such for the basic phrase convenience variables to work. If that is too hard, remove the simulation options for phrase cues.

@brunchboy brunchboy added the bug label Mar 15, 2023
@brunchboy
Copy link
Member Author

brunchboy commented Mar 27, 2023

A potential avenue to address this would be to add the song structure tag to either or both of the sample tracks already embedded in the Jar for simulated OBS overlays when offline. Then the phrase structure simulation functions could create status objects that correlated with phrases from within those sample tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant