Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configurable ip and port arguments #99

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Adding configurable ip and port arguments #99

merged 1 commit into from
Jul 9, 2018

Conversation

KingAkeem
Copy link
Member

@KingAkeem KingAkeem commented Jul 5, 2018 •
edited
Loading

Adds flags for setting ip and port individually or together, also fixed some PEP8 issues with complexity and line length. This references issue #98

@KingAkeem KingAkeem self-assigned this Jul 5, 2018
@KingAkeem KingAkeem requested review from PSNAppz and mamarto July 5, 2018 00:49
PSNAppz
PSNAppz approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work !

@PSNAppz PSNAppz merged commit 87cb7d5 into DedSecInside:dev Jul 9, 2018
@KingAkeem KingAkeem deleted the configurable_ip/port branch July 15, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSNAppz PSNAppz PSNAppz approved these changes

@mamarto mamarto Awaiting requested review from mamarto

Assignees

@KingAkeem KingAkeem

Labels
Enhancement Low Priority Merge Approved New Feature PEP8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KingAkeem @PSNAppz