Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP8 code and fixed some minor bugs #44

Merged
merged 2 commits into from
Jan 9, 2018
Merged

PEP8 code and fixed some minor bugs #44

merged 2 commits into from
Jan 9, 2018

Conversation

KingAkeem
Copy link
Member

@KingAkeem KingAkeem commented Jan 6, 2018 •
edited by PSNAppz
Loading

#43

PSNAppz
PSNAppz requested changes Jan 6, 2018
View reviewed changes
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases are failing.

@PSNAppz
Copy link
Member

PSNAppz commented Jan 6, 2018

@KingAkeem Check the test cases. Make sure those are passing.

@PSNAppz PSNAppz added this to the TorBot V1.1 milestone Jan 6, 2018
@PSNAppz
Copy link
Member

PSNAppz commented Jan 6, 2018

@DedSecInside/reviewers Please review.

@PSNAppz PSNAppz added To Review and removed Ongoing labels Jan 6, 2018
PSNAppz
PSNAppz approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Approved @KingAkeem Great work. Thank you for the Contribution.

@PSNAppz PSNAppz merged commit 65415da into DedSecInside:dev Jan 9, 2018
@KingAkeem
Copy link
Member Author

Thank you guys for letting me contribute. I'd like to add some more contributions, like setting up more tests, removing redundancy and refactoring code.

@agrepravin
Copy link
Contributor

sounds awesome, go ahead mate @KingAkeem

@KingAkeem
Copy link
Member Author

Thanks, I'm fairly new to open source and really like your project. Do you guys have a gitter?

@PSNAppz
Copy link
Member

PSNAppz commented Jan 9, 2018 •
edited
Loading

We use slack for communication. @KingAkeem
I have added you to our Team join us using the link which is there in your email.

@KingAkeem
Copy link
Member Author

I haven't received the link, could you send it to me again at akeemtlking@gmail.com?

@PSNAppz
Copy link
Member

PSNAppz commented Jan 10, 2018

See this Link

@KingAkeem
Copy link
Member Author

I'm getting this error
Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account.

@KingAkeem
Copy link
Member Author

Trying inviting me on Slack at atking1@coastal.edu

@PSNAppz
Copy link
Member

PSNAppz commented Jan 10, 2018

Ok done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSNAppz PSNAppz PSNAppz approved these changes

Assignees

@KingAkeem KingAkeem

Labels
Enhancement Low Priority Merge Approved PEP8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KingAkeem @PSNAppz @agrepravin