Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize torbot #167

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Dockerize torbot #167

merged 2 commits into from
Oct 2, 2019

Conversation

v1shwa
Copy link
Contributor

@v1shwa v1shwa commented Oct 1, 2019

Fixes #164

Changes Proposed

  • Add Dockerfile

Explanation of Changes

  • Ability to run torbot within a docker container.
  • Updated README to add instructions to run on docker.

@v1shwa
Copy link
Contributor Author

v1shwa commented Oct 1, 2019

@PSNAppz Please review it & let me know if I missed something. :)

@PSNAppz PSNAppz requested a review from KingAkeem October 1, 2019 07:17
@PSNAppz
Copy link
Member

PSNAppz commented Oct 1, 2019

Thank you @v1shwa for the PR.
@KingAkeem please review and merge

@KingAkeem KingAkeem added this to the TorBot V1.4 milestone Oct 1, 2019
@KingAkeem
Copy link
Member

What are the instructions for testing this?

@v1shwa
Copy link
Contributor Author

v1shwa commented Oct 2, 2019

@KingAkeem I have added in the README. But, here you go, again:

  • Ensure than you have a tor container running on port 9050. You can start on by running: docker run -p 9050:9050 -d --name tor osminogin/tor-simple

  • Build docker image: docker build -t dedsecinside/torbot .

  • Run the container (make sure to link the tor container as tor):

    docker run --link tor:tor --rm -ti dedsecinside/torbot

KingAkeem
KingAkeem approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and LGTM. Thank you for your contribution!

@KingAkeem KingAkeem merged commit 72c1e16 into DedSecInside:dev Oct 2, 2019
@v1shwa v1shwa deleted the dockerize branch October 2, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingAkeem KingAkeem KingAkeem approved these changes

Assignees
No one assigned
Labels
Enhancement Hacktoberfest HackToberFest 2023 Merge Approved
Projects
None yet
Milestone
TorBot v1.4
Development

Successfully merging this pull request may close these issues.

Dockerize TorBot
3 participants
@v1shwa @PSNAppz @KingAkeem