Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes file #135

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Add .gitattributes file #135

merged 1 commit into from
Oct 29, 2018

Conversation

ChaminW
Copy link
Contributor

@ChaminW ChaminW commented Oct 14, 2018

Changes Proposed

This file will normalize the way handles the line endings as the file format.

KingAkeem
KingAkeem requested changes Oct 15, 2018
View reviewed changes
Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't quite understand the use of this addition. Could you give me a brief explanation?

@PSNAppz PSNAppz closed this Oct 28, 2018
@ChaminW
Copy link
Contributor Author

ChaminW commented Oct 29, 2018

This pull request adds a .gitattributes file in the root of the project indicating text=auto so that Git clients will automatically convert line endings to the correct platform line endings when cloning, and normalize them back to LF when committing. Further, adding separate configurations for identified file formats to leave untouched as binary.

@PSNAppz
Copy link
Member

PSNAppz commented Oct 29, 2018

@KingAkeem Please review this.

@PSNAppz PSNAppz reopened this Oct 29, 2018
@KingAkeem
Copy link
Member

This pull request adds a .gitattributes file in the root of the project indicating text=auto so that Git clients will automatically convert line endings to the correct platform line endings when cloning, and normalize them back to LF when committing. Further, adding separate configurations for identified file formats to leave untouched as binary.

Thanks for the explanation, sounds like a great idea!

@PSNAppz
Copy link
Member

PSNAppz commented Oct 29, 2018

@ChaminW Great work 👏🏻

@PSNAppz PSNAppz merged commit 81fbd39 into DedSecInside:dev Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingAkeem KingAkeem KingAkeem approved these changes

Assignees
No one assigned
Labels
Good First Issue Hacktoberfest HackToberFest 2023 Low Priority Merge Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaminW @PSNAppz @KingAkeem