Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Card): add card component #98

Merged
merged 1 commit into from
Mar 13, 2023
Merged

feat(Card): add card component #98

merged 1 commit into from
Mar 13, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Feb 3, 2023 •
edited by ManonPolle
Loading

Changes description 🧑‍💻

Add the card component

Context 🤔

Closes #5

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Screenshot_20230203_161010

Other info 👋

@FDELAHA24 FDELAHA24 self-assigned this Feb 3, 2023
@FDELAHA24 FDELAHA24 requested review from ManonPolle and a team as code owners February 3, 2023 15:11
@FDELAHA24 FDELAHA24 requested a review from a team February 3, 2023 15:11
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/ca22f5c9-7910-482e-9248-4802a1f15990/artifact/645d1342152199f9/p/0cb7259e112ae3cfd625c653c4efa41f

ManonPolle
ManonPolle requested changes Feb 3, 2023
View reviewed changes
cards/README.md Outdated Show resolved Hide resolved
@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Feb 9, 2023
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/00242aec-10a1-46dc-aafc-9e3003c3d615/artifact/fddf550c32596813/p/4eb044e9f33d3e7d65807c4f3b3efbe8

@FDELAHA24 FDELAHA24 force-pushed the feat/card branch 2 times, most recently from 7207ac9 to 4cef4f3 Compare February 24, 2023 09:04
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/e848ec2e-1ff3-49d1-84ce-3586c42f7330/artifact/f32752ca50e23a56/p/8d816311b2033d2793cb269cdc307457

ManonPolle
ManonPolle previously approved these changes Feb 24, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a68c48f6-6a81-453a-b950-d1df15205fc9/artifact/de56b5b87b5d5fa3/p/45dfda8d8b6f6e532a7647c6ae56df0f

GerardPaligot
GerardPaligot previously approved these changes Mar 9, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/fd09e4f3-4ec7-4db2-ac10-a9120bfc33d0/artifact/5cd27eab836b1b66/p/5572ee11c1b8e240aef712f4c70901ca

Sabrinavigil
Sabrinavigil reviewed Mar 13, 2023
View reviewed changes
Copy link

@Sabrinavigil Sabrinavigil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed :) Ok for me thank you @FDELAHA24 !

@ManonPolle ManonPolle merged commit 0496a1f into Decathlon:main Mar 13, 2023
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
@DamienLevel DamienLevel mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabrinavigil Sabrinavigil Sabrinavigil left review comments

@ManonPolle ManonPolle ManonPolle approved these changes

@corentin-stamper corentin-stamper corentin-stamper left review comments

@GerardPaligot GerardPaligot GerardPaligot left review comments

Assignees

@FDELAHA24 FDELAHA24

Labels
enhancement 🚀 New feature or request
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

feat: add Card Component
7 participants
@FDELAHA24 @dktbitrise @GerardPaligot @corentin-stamper @ManonPolle @Sabrinavigil @lauthieb