Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quantity): remove component fixed size #70

Merged
merged 3 commits into from
Jan 19, 2023
Merged

feat(quantity): remove component fixed size #70

merged 3 commits into from
Jan 19, 2023

Conversation

adrienbusin
Copy link
Contributor

@adrienbusin adrienbusin commented Jan 13, 2023 •
edited by ManonPolle
Loading

Changes description 🧑‍💻

remove component fixed size

Context 🤔

Decathlon/vitamin-design#162

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋

@adrienbusin adrienbusin requested review from a team as code owners January 13, 2023 10:32
@ManonPolle
Copy link
Contributor

Waiting for this issue to be closed : Decathlon/vitamin-design#162

@dktbitrise
Copy link

You can download the apk here :

1 similar comment
@dktbitrise
Copy link

You can download the apk here :

@adrienbusin adrienbusin force-pushed the feature/quantity_size branch from cd046a4 to b12e4fa Compare January 13, 2023 13:00
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/3d0c8ba6-a89d-4df4-92f8-51c9cea6502d/artifact/17e1e8fd28812652/p/6fdbf8b824274e86d94f6a439cd19582

@ManonPolle ManonPolle requested a review from a team January 13, 2023 13:51
@lauthieb lauthieb added run 💨 enhancement 🚀 New feature or request labels Jan 17, 2023
@adrienbusin adrienbusin force-pushed the feature/quantity_size branch 2 times, most recently from f125467 to b765522 Compare January 18, 2023 09:02
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/971d325c-80fc-4dd2-bd72-fe1d3bb3bb9b/artifact/acced12277893bb2/p/3b4a28b781484fbea2de37edc55b482b

@ManonPolle ManonPolle force-pushed the feature/quantity_size branch from b765522 to ee7f9fd Compare January 19, 2023 14:59
@ManonPolle ManonPolle force-pushed the feature/quantity_size branch from ee7f9fd to 78ca0ea Compare January 19, 2023 15:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/474765d0-9c84-4976-89f0-2e3059893254/artifact/a40ab25a568a09be/p/0680e566a02847085483d996b60167d8

@ManonPolle ManonPolle merged commit bbc539a into Decathlon:main Jan 19, 2023
@ManonPolle ManonPolle mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@adrienbusin adrienbusin

Labels
enhancement 🚀 New feature or request
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrienbusin @ManonPolle @dktbitrise @SimonLeclercq @lauthieb