Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(switches): add paparazzi tests #118

Merged
merged 5 commits into from
Jun 22, 2023
Merged

chore(switches): add paparazzi tests #118

merged 5 commits into from
Jun 22, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Mar 3, 2023 •
edited by ManonPolle
Loading

Changes description 🧑‍💻

Add paparazzi tests

Context 🤔

Closes #95
Resolves #147

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋

@FDELAHA24 FDELAHA24 requested review from ManonPolle and a team as code owners March 3, 2023 15:53
@dktbitrise
Copy link

You can download the apk here :

@FDELAHA24 FDELAHA24 force-pushed the feat/switch_paparazzi_tests branch from 77e83de to b23ed9e Compare March 3, 2023 16:27
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/abd6932b-739b-483d-8519-d9783a38fdd8/artifact/a9b318b0288603ee/p/9429124f56ebc0d32014a3c1d94fc343

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/560a2326-4e3d-4fe8-bb7e-df2aeadb7ad8/artifact/0749572cc590af64/p/fa0647c8e212b3c8f88c38385638df61

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/abdd3588-ab77-4155-abbe-c7e2f2825640/artifact/cbb93832488fdf00/p/31e9fa35cb68c1e6c45bf1fa91ebab38

GerardPaligot
GerardPaligot requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@GerardPaligot GerardPaligot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an internal discussion with @SimonLeclercq, the thumb in dark mode shouldn't be dark like that.
Tracking issue: Decathlon/vitamin-design#216

@FDELAHA24 FDELAHA24 self-assigned this Mar 10, 2023
@ManonPolle ManonPolle added this to the 0.3.0 milestone Mar 16, 2023
@FDELAHA24 FDELAHA24 force-pushed the feat/switch_paparazzi_tests branch from b23ed9e to 3278c17 Compare March 17, 2023 16:13
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bb02888d-ab16-4ae0-820d-4e8c3390ddc9/artifact/ccc6ab46c5080061/p/50437091d30f4d3ff60e9eb7b648b3fa

@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Mar 21, 2023
@corentin-stamper corentin-stamper force-pushed the feat/switch_paparazzi_tests branch from 3278c17 to 8b0eae1 Compare April 6, 2023 07:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/3f5f0de5-4d56-4222-b981-654b8e3f1984/artifact/1b81c33e6944ccc5/p/034321b6ea5e2cbedf4e4e50de0a9c4e

@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@ManonPolle ManonPolle force-pushed the feat/switch_paparazzi_tests branch from 8b0eae1 to dae2ee0 Compare May 17, 2023 08:27
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/e6286a67-2e82-486d-988f-e16b15863b5e/artifact/6cd8365fb667b0a3/p/766fe6e4df5db60f10cd3b1155bf8efe

@ManonPolle ManonPolle requested review from a team and GerardPaligot May 17, 2023 12:36
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a11d692d-a7b8-4f97-9a2f-c2b399204bc6/artifact/ef04407792fdfe3f/p/9c0aad964beccd9e9f00793b66a219e3

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/9e2f522c-7346-484b-a683-7d0811cd7559/artifact/558a2987f87d7b46/p/d692cc1dc661c3744cf639704c005a01

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/d67c97e1-d921-4ac3-8866-728d7b9d4ab3/artifact/db217e21add011ec/p/86c7eeb6ee4c6fe954da784ca78bcddc

@ManonPolle ManonPolle merged commit a3be2ab into Decathlon:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardPaligot GerardPaligot GerardPaligot approved these changes

@corentin-stamper corentin-stamper corentin-stamper left review comments

@ManonPolle ManonPolle Awaiting requested review from ManonPolle ManonPolle is a code owner

Assignees

@FDELAHA24 FDELAHA24

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
0.3.0
6 participants
@FDELAHA24 @dktbitrise @GerardPaligot @corentin-stamper @lauthieb @ManonPolle