Stop modifying upstream .gitignore file and put build artifacts in debian/build/ #248
Conversation
…urces Instead of putting build artifacts in `_build/` at the project root, where they pollute the upstream sources and lure some people to also modify the upstream `.gitignore` file, put it in `debian/build/` along with all other build artifacts that get generated in `debian/`.
The fact that Debian builds produce extra files in the build directory is a separate concern and should not be managed by .gitignores in upstream directory. Anyways, the list is not going to be complete on most packages, and instead of extending the list, a better practice is to have proper `make clean` rules in the `debian/rules`, or to simply run `git clean -fdx` between builds. Additionally, everyone should be using `gbp pq` to update patches instead of legacy Quilt, so no more `.pc` directories should be generated.
| fmt.Fprintf(f, "\tdh $@ --builddirectory=debian/build --buildsystem=golang\n") | ||
| // Note: The above `--builddirectory=debian/build` will eventually be obsolete | ||
| // in 2028+ then the dh-golang version 1.63+ that has | ||
| // https://salsa.debian.org/go-team/packages/dh-golang/-/commit/bc16dff5381b668a71fa99c381baba202c34c789 | ||
| // is in use everywhere | ||
|
|
There was a problem hiding this comment.
Considering dh-golang 1.63 is already in testing, I think we could remove this completely. After all, these tools are meant to be used from sid..
There was a problem hiding this comment.
The omission of the --builddirectory option is dependent on the debhelper compat level, see the dh-golang(1) man page for the rationale, and debhelper compat 14 is not yet stable.
From the commit reverting the previous change: So, I agree with the idea of the change, but probably not in this specific form. |
|
In summary, the proposal from 2020 in https://lists.debian.org/debian-dpkg/2020/03/msg00003.html is instead of all these and more: ..just have this: with all artifacts there. This would certainly help keep the |
See commits for details. This is a re-submission of #230, pending to be merged potentially in the summer of 2025.