Ashenvale: Add cross-raid boss health syncing #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic idea is to set wow.base_path in your global VS Code config to whereever you have WoW installed and then bind this script to some hotkey (I have it on Ctrl+D), it then copies the addon from whereever you are developing it to all variants of the game. Requires Linux, macOS, or WSL2 with rsync installed. It's a bit slow on WSL, I guess someone who carse about windows should write a PowerShell variant...
Observed boss health for Ashenvale is now synced to both RAID and YELL chats. We also propagate syncs received from one to the other. The idea is to use YELL chat to propagate from one raid to another. Basically if a raid has a player at boss A and another player at boss B then the player at B will know health of A and propagate to others at A. These, in turn, will tell their raid who may have someone at boss C who then tells others at boss C etc. Syncs are limited to 10 messages per second total (across both chats), and I'm attempting to do some basic prevention of duplicate sending, but it's not super reliable because there are large latencies involved. Also refactor the HealthTracker a bit, it's no longer some weird singleton with some effectively global state. It's now an object which you should only have a single instance of because of singleton-like dependencies it has. Anyhow, this cleans up state management and resolves some problems with multiple event registrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.