-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing license to GPL-2.0 #17
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to sign off kernel code changes (git commit -s
).
In this case, since you merged my trivial cleanup to this file, please record my consent to relicensing
Acked-by: Andreas Färber <afaerber@suse.com>
before your own Signed-off-by:
line. (File history: https://github.com/DeGirum/lincdadrv/commits/master/src/cdaioctl.h -- I seem the only non-employee so far)
It would also be useful to reference my #16 in the pull request description (optionally in the commit message of the license change) to generate links within GitHub.
Another consideration is who you expect to compile against this ioctl declaration file: If under LGPL, then there would need to be an LGPL'ed library (or GPL'ed tool) consuming it. If you want to allow for proprietary libraries/tools to consume it (current PySDK), then you may want to consider dual-licensing this file as "GPL-2.0 OR MIT" (or BSD-3-clause) or use "GPL-2.0 WITH Linux-syscall-note" (cf. https://spdx.org/licenses/Linux-syscall-note.html -- not sure whether applicable here, since ioctl rather than syscall; compare the kernel tree for examples).
@@ -1,4 +1,4 @@ | |||
/* SPDX-License-Identifier: GPL-2.0 */ | |||
/* SPDX-License-Identifier: LGPL-2.1 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you're clear on which license you want, you should probably squash these two commits (git rebase -i HEAD~3
).
And title has not yet been updated to LGPL. |
No description provided.