Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jellyfish-transaction-builder): add interface on the same package #2158

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

pierregee
Copy link
Contributor

What this PR does / why we need it:

Having package build issues, need to make the package agnostic
image

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 32a416b
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/65128a2aab7dbe0008591232
😎 Deploy Preview https://deploy-preview-2158--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/packages kind/chore Non feature change labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2158 (32a416b) into main (8baa393) will decrease coverage by 2.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   90.71%   88.06%   -2.65%     
==========================================
  Files         371      372       +1     
  Lines       11228    11243      +15     
  Branches     1468     1468              
==========================================
- Hits        10185     9901     -284     
- Misses        989     1284     +295     
- Partials       54       58       +4     
Files Coverage Δ
...llyfish-transaction-builder/src/txn/txn_builder.ts 98.24% <ø> (ø)
...transaction-builder/src/txn/txn_builder_account.ts 64.10% <ø> (+10.25%) ⬆️

... and 117 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 13e3d45

  • ghcr.io/birthdayresearch/legacy-api:pr-2158
  • ghcr.io/birthdayresearch/playground-api:pr-2158
  • ghcr.io/birthdayresearch/status-api:pr-2158
  • ghcr.io/birthdayresearch/whale-api:pr-2158

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:13e3d457e24f8245819a1d83e609a006a6d6c28a
  • ghcr.io/birthdayresearch/playground-api:13e3d457e24f8245819a1d83e609a006a6d6c28a
  • ghcr.io/birthdayresearch/status-api:13e3d457e24f8245819a1d83e609a006a6d6c28a
  • ghcr.io/birthdayresearch/whale-api:13e3d457e24f8245819a1d83e609a006a6d6c28a

@pierregee pierregee marked this pull request as ready for review September 26, 2023 08:07
@thedoublejay thedoublejay merged commit 950b21c into main Sep 26, 2023
@thedoublejay thedoublejay deleted the pierregee/make-txn-builder-agnostic branch September 26, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants