Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace more require usages #1822

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Replace more require usages #1822

merged 2 commits into from
Mar 15, 2023

Conversation

Bushstar
Copy link
Member

Continue the replacement of Require which performs worse than conventional conditional statements.

prasannavl
prasannavl approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@prasannavl prasannavl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM.

@prasannavl prasannavl requested a review from DocteurPing March 15, 2023 12:43
@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Mar 15, 2023
@prasannavl prasannavl merged commit b13baca into master Mar 15, 2023
@prasannavl prasannavl deleted the require-replace-icx branch March 15, 2023 13:45
@dcorral dcorral mentioned this pull request Mar 17, 2023
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

@DocteurPing DocteurPing Awaiting requested review from DocteurPing

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bushstar @prasannavl