Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: rate limit the processing of incoming addr messages #1818

Merged
merged 6 commits into from
Mar 15, 2023
Merged

net: rate limit the processing of incoming addr messages #1818

merged 6 commits into from
Mar 15, 2023

Conversation

Bushstar
Copy link
Member

Adds the following Bitcoin back port from Dogecoin to our codebase to apply a rate limiter to the addr network P2P message.

dogecoin/dogecoin#3008

Mixa84
Mixa84 previously approved these changes Mar 14, 2023
View reviewed changes
@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Mar 15, 2023
@prasannavl
Copy link
Member

prasannavl commented Mar 15, 2023 •
edited
Loading

Logic LGTM.

To finish the backport integration:

  • Tests: Set a much larger rate limit for regtests (so we're able to test this as well later)
  • SPV: Reimplement token bucket for SPV to addr to add rate limit there as well. Determined to be not needed.

prasannavl
prasannavl reviewed Mar 15, 2023
View reviewed changes
src/net_processing.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl merged commit 40fa4e4 into master Mar 15, 2023
@prasannavl prasannavl deleted the addr-rate-limiter branch March 15, 2023 12:53
@dcorral dcorral mentioned this pull request Mar 17, 2023
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl left review comments

@Mixa84 Mixa84 Mixa84 left review comments

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bushstar @prasannavl @Mixa84