Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CreateTransaction pass coinSelectOpts to AvailableCoin. Remove dead code. #1814

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Mar 9, 2023

Skips dummy signing in AvailableCoin() when being called with -walletfastselect or -walletcoinoptskipsolvable for applicable RPC calls, also pass on opts from calls to fund() to CreateTransaction(). Remove non-DFI UTXO dead code in CreateTransaction.

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Mar 9, 2023
Jouzo
Jouzo previously approved these changes Mar 9, 2023
prasannavl
prasannavl previously approved these changes Mar 9, 2023
@Bushstar Bushstar dismissed stale reviews from prasannavl and Jouzo via 6f816f8 March 9, 2023 02:54
Jouzo
Jouzo previously approved these changes Mar 9, 2023
@prasannavl prasannavl merged commit f0f47b2 into master Mar 9, 2023
@prasannavl prasannavl deleted the dead-code-token branch March 9, 2023 03:50
@dcorral dcorral mentioned this pull request Mar 17, 2023
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants