Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetDecimalString typo #1812

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Fix GetDecimalString typo #1812

merged 2 commits into from
Mar 9, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Mar 8, 2023 •
edited
Loading

/kind fix

  • This indicates the end of an era.
  • Fixes the incorrect function name GetDecimaleString that had become an affectionate typo through the years

@prasannavl prasannavl requested a review from Bushstar March 8, 2023 15:36
@Bushstar
Copy link
Member

Bushstar commented Mar 9, 2023

I will miss GetDecimaleString 😢

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Mar 9, 2023
@prasannavl prasannavl merged commit 3be2c92 into master Mar 9, 2023
@prasannavl prasannavl deleted the pvl/get-decimal-string-typo branch March 9, 2023 03:32
@dcorral dcorral mentioned this pull request Mar 17, 2023
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocteurPing DocteurPing DocteurPing approved these changes

@Jouzo Jouzo Jouzo approved these changes

@Bushstar Bushstar Bushstar approved these changes

@shohamc1 shohamc1 Awaiting requested review from shohamc1

Assignees

@prasannavl prasannavl

Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasannavl @Bushstar @Jouzo @DocteurPing