Add missing CalculateOwnerRewards calls #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should test the performance impact of this on the block, just to get an estimate before merging. |
prasannavl
added
the
v/next-network-upgrade
Merged
Bushstar
changed the title
prasannavl
added
v/3.2.7
and removed
v/next-network-upgrade
Jouzo
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before SubBalance is called CalculateOwnerRewards should also be called to make sure the expected pool rewards are present. When AddBalance is called on a new address that might not have been seen by the network before CalculateOwnerRewards should be called to add that address to the account index.
This PR adds one missing call to CalculateOwnerRewards before SubBalance in the currently unused DFIP2201 smart contract. There are also a missing CalculateOwnerRewards calls for AddBalance on CWithdrawFromVaultMessage.
Now that we know that all other SubBalance calls that are currently in use have a corresponding CalculateOwnerRewards call we can remove the fork guards around other calls to this function that were restored in a more cautious manner.
Resolves:
#1763