New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeFiErrors abstraction for error messages #1758

Merged

prasannavl merged 2 commits into master from pvl/errors

Feb 16, 2023

Member

prasannavl commented Feb 11, 2023

/kind refactor

Add DeFiErrors class that abstracts error messages.
Provide meaningful parameters and construct errors message from it in a coherent way than similar, but different messages across the codebase.
Eventually use this to slowly add error codes than just messages for external APIs to rely on.


          Add DeFiErrors abstraction for error messages

8a2b4b0

defichain-bot added the kind/refactor label

defichain-bot assigned prasannavl


          Fix lint

b77a82a

Bushstar approved these changes

View reviewed changes

Member Author

prasannavl commented Feb 16, 2023

Kickstarts the pattern to refactor error message. Merging to get this done in peace-meals later, but to have fresh code follow this.
Jellyfish still on failures due to Ubuntu 18 deprecation. Ignoring and merging.

prasannavl merged commit c686a5b into master

prasannavl deleted the pvl/errors branch

February 16, 2023 01:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet