Revert "Update Bitcoin DNS seeds (#1545)" #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a7a4c58.
Bushstar
requested review from
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a change to the DNS seeds which results in heavy resolver usage. The seeds restored in this PR are the sames ones used in BreadWallet-Core today.
https://github.com/breadwallet/breadwallet-core/blob/73566cb79f753954eccbf07d5ab25ca54741198e/bitcoin/BRChainParams.c#L28-L36
The changes reverted by this PR resulted in ~37% of CPU time trying to resolve the new DNS seed entries. When testing the new entries one failed to resolve with a DNS query, presumably it is this entry that caused the issue with some aggressive DNS resolution loop.