Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MineBlocksOnDemand on mocknet #1638

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Dec 7, 2022

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

  • Allows MineBlocksOnDemand

@prasannavl
Copy link
Member

prasannavl commented Dec 8, 2022

Good thought. Would it be better to set fNoRetargeting only on mocktime being set?

Alternatively, we can remove the branch that currently overrides for mocknet, and reuse mocktime to use a default proof of work limit from params.pos.diffLimit.

@Jouzo
Copy link
Contributor Author

Jouzo commented Dec 8, 2022

Good thought. Would it be better to set fNoRetargeting only on mocktime being set?

Alternatively, we can remove the branch that currently overrides for mocknet, and reuse mocktime to use a default proof of work limit from params.pos.diffLimit.

Agree. The idea behind this PR is to be able to use setmocktime in order to generatetoaddress faster, as being done in test framework.
I changed a bit the logic, reverted setting fNoRetargeting on mocknet and updated MineBlocksOnDemand directly to restrict side effects.

@Jouzo Jouzo changed the title Set fNoRetargeting on mocknet Allow MineBlocksOnDemand on mocknet Dec 8, 2022
@Jouzo Jouzo added v/3.2.1 and removed v/3.2.1 labels Dec 28, 2022
@prasannavl prasannavl merged commit ab44fbd into master Jul 15, 2024
@prasannavl prasannavl deleted the chore/setmocktime_mocknet branch July 15, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants