Merge pull request #423 from De-Panther/fix_onhandupdate_unsubscribe

Fixed WebXRInputSystem unsubscribe OnHandUpdate OnDisable
De-Panther · Feb 25, 2025 · daaefe4 · daaefe4
2 parents afec992 + 145d5c0
commit daaefe4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Packages/webxr-interactions/CHANGELOG.md b/Packages/webxr-interactions/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- WebXRInputSystem unsubscribe OnHandUpdate OnDisable. (Issue #422)
+
 ## [0.22.0] - 2024-02-25
 ### Added
 - Sample Scene - Built-in Render Pipeline.

diff --git a/Packages/webxr-interactions/Runtime/InputSystem/WebXRInputSystem.cs b/Packages/webxr-interactions/Runtime/InputSystem/WebXRInputSystem.cs
@@ -122,7 +122,7 @@ private void OnDisable()
       WebXRManager.OnXRChange -= OnXRChange;
       WebXRManager.OnControllerUpdate -= OnControllerUpdate;
 #if XR_HANDS_1_1_OR_NEWER
-      WebXRManager.OnHandUpdate += OnHandUpdate;
+      WebXRManager.OnHandUpdate -= OnHandUpdate;
       webXRHandsSubsystem?.Stop();
       subsystemUpdater?.Stop();
 #endif