CI - Reuse organisation's workflows to lint, test, tag and publish #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
changed the title
MrChocolatine
added
internal
GreatWizard
approved these changes
Nov 2, 2021
MrChocolatine
force-pushed
the
ci-reuse-org-workflows
branch
from
e8b185a
to
441a2b5
Compare
|
We currently have an error during the tests with Embroider: https://github.com/peopledoc/ember-reading-time/actions/runs/1409500930 Related issue: embroider-build/embroider#1004 Edit Apparently we can't do much because of a setting for Webpack v4: embroider-build/embroider#1004 (comment) Edit I found a fix, see the commits stack. |
MrChocolatine
force-pushed
the
ci-reuse-org-workflows
branch
19 times, most recently
from
6418ad3
to
04634c8
Compare
GreatWizard
approved these changes
Nov 3, 2021
GreatWizard
approved these changes
Nov 3, 2021
MrChocolatine
force-pushed
the
ci-reuse-org-workflows
branch
from
04634c8
to
05b2706
Compare
``` ember-cli-update --to 3.28 ```
These changes aim to fix the following errors: https://github.com/peopledoc/ember-reading-time/actions/runs/1409500930 _Extract of the error:_ ``` - broccoliBuilderErrorStack: ModuleNotFoundError: Module not found: Error: Can't resolve 'stream' in '/home/runner/work/ember-reading-time/ember-reading-time/node_modules/reading-time/lib/stream.js' Did you mean './stream'? Requests that should resolve in the current directory need to start with './'. Requests that start with a name are treated as module requests and resolve within module directories (node_modules). If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too. BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it. If you want to include a polyfill, you need to: - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }' - install 'stream-browserify' ``` During the Embroider tests the Node.js module `stream` couldn't be found because, in these tests, Webpack v5 is used, instead of the v4 used by `ember-auto-import@v1` (see `yarn why webpack`). This code was telling Webpack to include the polyfill for `stream`: https://github.com/peopledoc/ember-reading-time/blob/v1.0.0/index.js#L7-L11 But this was only understood by Webpack v4: - embroider-build/embroider#1004 (comment) - https://v4.webpack.js.org/configuration/node/#other-node-core-libraries In Webpack v5, Node.js polyfills are *NOT* automatically included: - https://gist.github.com/ef4/d2cf5672a93cf241fd47c020b9b3066a - https://github.com/ef4/ember-auto-import/blob/v2.2.3/docs/upgrade-guide-2.0.md#webpack-5-upgrade - https://webpack.js.org/configuration/node/ > As of webpack 5, You can configure only `global`, `__filename` or > `__dirname` under `node` option. If you're looking for how to > polyfill `fs` alike in Node.js under webpack 5, please check > `resolve.fallback` for help.
MrChocolatine
force-pushed
the
ci-reuse-org-workflows
branch
from
05b2706
to
e0da4af
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Update
ember-clito version 3.28.3 (#13)Update
@embroider/test-setupto v0.47.1 (#13)CI
Reuse organisation's workflow to run lint & tests (#13)
This change also activates the tests for Embroider, where a specific configuration had to be found in order to make these tests pass. See the commits stack.
Reuse organisation's workflow to run tag & publish (#13)