-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter TypeScript settings #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
changed the title
stricter typescript settings
Stricter TypeScript settings
Jun 4, 2021
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
from
June 4, 2021 14:49
3f80791
to
7375001
Compare
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
from
July 9, 2021 11:44
7375001
to
bdf849c
Compare
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
3 times, most recently
from
September 3, 2021 17:54
21ac098
to
f172dba
Compare
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
from
September 3, 2021 18:02
f172dba
to
85fad7b
Compare
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
2 times, most recently
from
September 6, 2021 11:19
af68751
to
bd5531e
Compare
ndekeister-us
approved these changes
Sep 8, 2021
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
5 times, most recently
from
September 9, 2021 16:45
b034356
to
2b6f625
Compare
https://www.typescriptlang.org/tsconfig#strict > Turning this on is equivalent to enabling all of the strict mode > family options ...
https://www.typescriptlang.org/tsconfig#noEmitOnError > Do not emit compiler output files like JavaScript source code, > source-maps or declarations if any errors were reported.
https://www.typescriptlang.org/tsconfig#forceConsistentCasingInFileNames > When this option is set, TypeScript will issue an error if a program > tries to include a file by a casing different from the casing on disk
https://www.typescriptlang.org/tsconfig#noImplicitOverride > When working with classes which use inheritance, it’s possible for a > sub-class to get “out of sync” with the functions it overloads when > they are renamed in the base class. > ... > Using `noImplicitOverride` you can ensure that the sub-classes never > go out of sync, by ensuring that functions which override include the > keyword `override`.
Why? When talking about "nullish values" we explicitly only refer to `null` and `undefined`: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator
1. This assertion is already included in another test. 2. Considering the title of the test "it defers the boot of the app", this assertion does not belong here.
MrChocolatine
force-pushed
the
stricter-typescript-settings
branch
from
September 9, 2021 16:45
2b6f625
to
1ca7087
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Enable TypeScript flag
strict
(#88)Enforce a stronger TypeScript configuration by enabling all of the strict mode family options.
https://www.typescriptlang.org/tsconfig#strict :
Enable TypeScript flag
noEmitOnError
(#88)From the add-on
ember-cli-typescript
:A good way to ensure nothing is emitted if errors are still detected.
Enable TypeScript flag
forceConsistentCasingInFileNames
(#88)A good safeguard to make the project even more bullet-proof.
https://www.typescriptlang.org/tsconfig#forceConsistentCasingInFileNames
Enable TypeScript flag
noImplicitOverride
(#88)https://www.typescriptlang.org/tsconfig#noImplicitOverride
Refactor
Disable redundant lint rules (#88)
Fix types definitions (#88)
Improve arguments of deprecation warnings (#88)
Test
Set more accurate types definitions (#88)
Remove logical expressions from
assert
(#88)Remove unnecessary
assert.expect()
(#88)