Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Tag-release-publish - Use Node.js v18 #310

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

MrChocolatine
Copy link
Member

@MrChocolatine MrChocolatine commented Nov 12, 2023

CI

Workflow "tag-release-publish", use Node.js v18 (#310)


Twin PR with: DazzlingFugu/ember-feature-controls#261

@MrChocolatine MrChocolatine added the ci Changes related to the CI label Nov 12, 2023
@MrChocolatine MrChocolatine requested a review from a team as a code owner November 12, 2023 21:38
@MrChocolatine MrChocolatine force-pushed the ci-remove-node-version-use-default-value branch from ce75983 to fce3ee6 Compare November 12, 2023 22:08
@MrChocolatine
Copy link
Member Author

MrChocolatine commented Nov 13, 2023

We need this PR approved and merged, the auto-tag & release is blocked due to Node.js v14 being currently used:
https://github.com/DazzlingFugu/ember-cli-embedded/actions/runs/6855336980/job/18640159490

And we may need the same here as well: DazzlingFugu/ember-feature-controls#261

@ndekeister-us ?

@MrChocolatine MrChocolatine force-pushed the ci-remove-node-version-use-default-value branch from fce3ee6 to 4483fa7 Compare November 13, 2023 20:27
@MrChocolatine MrChocolatine changed the title CI - Tag-release-publish - Remove node-version and use default value CI - Tag-release-publish - Use Node.js v18 Nov 13, 2023
@MrChocolatine
Copy link
Member Author

@DazzlingFugu/emberenos

@MrChocolatine MrChocolatine merged commit fb28d97 into master Nov 15, 2023
9 checks passed
@MrChocolatine MrChocolatine deleted the ci-remove-node-version-use-default-value branch November 15, 2023 20:04
@MrChocolatine MrChocolatine mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes related to the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants