Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 3.1.0 #285

Merged
merged 1 commit into from
Aug 10, 2023
Merged

release: 3.1.0 #285

merged 1 commit into from
Aug 10, 2023

Conversation

Pixelik
Copy link
Contributor

@Pixelik Pixelik commented Aug 9, 2023

Chore

Dependabot updates

Features

Incorporates ember-export-application-global initializer (#273)

  • removes ember-export-application-global dependency
  • creates export-application-global initializer
  • adds @ember/string dependency (used by the above initializer) as it's no longer available in Ember 5 internally
  • adds relevant tests
  • updates documentation

Features

ember-cli/ember-export-application-global has been deprecated and archived. But an exported application global is essential to an embedded SPA and therefore to ember-cli-embedded as well. So rather than adding a deprecated/archived module as a dependency to this addon, or to an app using this addon, this commit now hardcodes the export-application-global initializer into the ember-cli-embedded module itself, therefore removing the need for an external dependency

Behaviour

  • An application global will be exported and attached to the window, without the need to set { exportApplicationGlobal: true } in config/environment.js, as long as { embedded: delegateStart: true } is set in config/environment.js
  • To avoid breaking changes with existing config/environment.js files, { exportApplicationGlobal: false } will still work, even though there is no need for it

screenshots of updated docs:

Screenshot 2023-06-19 at 12 16 05 Screenshot 2023-06-19 at 12 16 22

@Pixelik Pixelik marked this pull request as ready for review August 9, 2023 13:53
@Pixelik Pixelik requested a review from a team as a code owner August 9, 2023 13:53
@Pixelik Pixelik self-assigned this Aug 9, 2023
@Pixelik Pixelik requested a review from ndekeister-us August 9, 2023 13:54
@Pixelik Pixelik merged commit de709d6 into master Aug 10, 2023
@Pixelik Pixelik deleted the release/3.1.0 branch August 10, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants