Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore
Dependabot updates
Features
Incorporates
ember-export-application-global
initializer (#273)ember-export-application-global
dependencyexport-application-global
initializer@ember/string
dependency (used by the above initializer) as it's no longer available in Ember 5 internallyFeatures
ember-cli/ember-export-application-global
has been deprecated and archived. But an exported application global is essential to an embedded SPA and therefore to ember-cli-embedded as well. So rather than adding a deprecated/archived module as a dependency to this addon, or to an app using this addon, this commit now hardcodes theexport-application-global
initializer into the ember-cli-embedded module itself, therefore removing the need for an external dependencyBehaviour
window
, without the need to set{ exportApplicationGlobal: true }
inconfig/environment.js
, as long as{ embedded: delegateStart: true }
is set inconfig/environment.js
config/environment.js
files,{ exportApplicationGlobal: false }
will still work, even though there is no need for itscreenshots of updated docs: