-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade ember-cli-typescript to v5.1.0 #195
Conversation
3ae18ab
to
f94c7bc
Compare
f94c7bc
to
6ee312f
Compare
I wanted to take a look yesterday sorry, I will try this evening. (but I haven't forgotten, it is still in my todo-list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions, but overall seems good to me, thanks for taking the time 👍 .
I trust you on the changes related to the "types" packages, I tried to make the upgrade on my side too and too many different errors (the entire tests suite would sometimes pass, sometimes not, something telling me our Initializer could not be found...).
And if for some reason we actually need every @types
packages for Ember.js (those automatically shipped with ember-cli-typescript
) then why not, it's not a big deal in the end).
20430bf
to
c291e9a
Compare
This reverts commit 0b431d5.
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
c291e9a
to
43a731e
Compare
43a731e
to
8c9187a
Compare
Build
Upgrade ember-cli-typescript to v5.1.0 (#195)
Also
@ts-ignore
aroundgetOwner
code, seegetOwner(this)
returnsunknown
type typed-ember/ember-cli-typescript#1471Chore
Run ember-cli-typescript blueprint (#195)
To be up to date with ember-cli-typescript config and recommandations in
tsconfig.json
Running blueprints also add back
@types/ember*
packages in devDependencies, which solves a side effect introduced by #157.@types/ember*
packages from our devDependencies, they will still be included by other packages but they will resolve to a version sometimes incompatible with other@types/ember__*
packages, resulting of type errors in buildExample of build failing when we remove some
@types/ember__x
packages that we don't use (like routing, engine, array... ; even after ayarn-deduplicate && yarn
):Run yarn-deduplicate && yarn (#195)
Fix build and test by resolving
@types/ember*
packages to one single version in theyarn.lock
(otherwise we would have sometimes two different versions for some@types/ember*
packages, which would leads to type conflicts when building app