-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
form_with
with validate: false
on Rails 8 exception fix
#975
form_with
with validate: false
on Rails 8 exception fix
#975
Conversation
Ah, the logger issue. Please allow me to fix the CI, I will then ask you to rebase |
form_with(validate: false) | ||
end | ||
|
||
assert_dom "form" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the meanwhile, this is for sure an issue to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change to what @grantbdev added in the issue if these are a better fit
def test_form_with_without_model_without_validation
form_with(url: '/posts') do |f|
concat f.text_field(:cost)
end
expected = whole_form_with('/posts') do
form_field('input', id: 'cost', name: 'cost', type: 'text')
end
assert_dom_equal expected, output_buffer
end
@maxnovee done, please rebase |
Great, all green. Can you:
|
Ensure that super `form_with` is called with the right arguments. Fix #974
b59fb1c
to
bbaac22
Compare
Thanks! I'll backport this change do |
My pleasure! Looking forward to get the hotfix. |
22.3.1 pushed to rubygems, thanks again |
that should fix #974