You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When config.i18n.raise_on_missing_translations is enabled, Rails 7.1 raises on missing translations also when a translation is not found in a validation error message. This did not happen in 7.0
For some custom validations, like timeliness, client side validations attempts to create a message for "timeliness" error, which is not present.
On Rails 7.0 this did not fail, and the output would have contained a missing translation error
Steps to reproduce*
Add a custom validation without a translation (validates :leave_date, timeliness: { on_or_after: -> { Time.current } })
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1
raises on missing translation error when validation messages are not
translated, which is a new behavior causing CSV to fail
For unsupported validations, like `comparison`, and custom validations,
like `timeliness`, CSV attempts to create a message for a key that
is not present.
This commit standardizes the behavior and fallbacks on "invalid" when
a translation is not found, which is supposed to be the desired
behavior for this use case
Close#920
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1
raises on missing translation error when validation messages are not
translated, which is a new behavior causing CSV to fail
For unsupported validations, like `comparison`, and custom validations,
like `timeliness`, CSV attempts to create a message for a key that
is not present.
This commit standardizes the behavior and fallbacks on "invalid" when
a translation is not found, which is supposed to be the desired
behavior for this use case
Close#920
When `config.i18n.raise_on_missing_translations` is enabled, Rails 7.1
raises on missing translation error when validation messages are not
translated, which is a new behavior causing CSV to fail
For unsupported validations, like `comparison`, and custom validations,
like `timeliness`, CSV attempts to create a message for a key that
is not present.
This commit standardizes the behavior and fallbacks on "invalid" when
a translation is not found, which is supposed to be the desired
behavior for this use case
Close#920
When
config.i18n.raise_on_missing_translations
is enabled, Rails 7.1 raises on missing translations also when a translation is not found in a validation error message. This did not happen in 7.0For some custom validations, like
timeliness
, client side validations attempts to create a message for "timeliness" error, which is not present.On Rails 7.0 this did not fail, and the output would have contained a missing translation error
Steps to reproduce*
validates :leave_date, timeliness: { on_or_after: -> { Time.current } }
)Expected behavior*
Does not fail
Actual behavior*
System configuration*
Rails version: 7.1
Ruby version: 3.2.2
Client Side Validations version: main
Code snippet from your model of the validations*
The whole form code from your template*
The resulting HTML*
not needed
Browser's development console output*
Additional JavaScript Libraries*
does not apply
Repository demostrating the issue
https://github.com/diowa/icare/tree/feature/rails-71
The text was updated successfully, but these errors were encountered: