Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing comma in setup.py requirements #2

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix missing comma in setup.py requirements #2

merged 1 commit into from
Aug 4, 2021

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Aug 4, 2021

This bug was found thanks to Poetry:

PackageInfo: Invalid constraint (djangorestframework-stubs>=0.4.0typing-extensions>=3.7.4) found in django-filter-stubs-0.1.1 dependencies, skipping

@intgr
Fix missing comma in setup.py requirements
3d6fa2d 
This bug was found thanks to Poetry:

> PackageInfo: Invalid constraint (djangorestframework-stubs>=0.4.0typing-extensions>=3.7.4) found in django-filter-stubs-0.1.1 dependencies, skipping
@DavisRayM DavisRayM merged commit 68ac858 into DavisRayM:master Aug 4, 2021
@DavisRayM
Copy link
Owner

Thanks for the contribution

@intgr
Copy link
Contributor Author

intgr commented Sep 26, 2022

Can you please make a release with this fix?

I don't understand why this started failing now and didn't fail before. But Poetry doesn't like it:

% poetry install
Installing dependencies from lock file
Could not parse version constraint: >=0.4.0typing-extensions

@intgr intgr mentioned this pull request Oct 11, 2022
Closed
@DavisRayM DavisRayM mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisRayM DavisRayM DavisRayM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @DavisRayM