fix(poly check): dependency/dists lookup performance improvements #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata, always run with same input
…dependencies and sub-dependencies
… also: unit tests resetting cached state before run
|
DavidVujic
changed the title
DavidVujic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving the performance of the
poly checkcommand, when doing dists lookups.This should make the command faster.
Motivation and Context
Distribution lookups (via the
importlibbuiltin) are expensive from a performance perspective. The metadata andfilesfetching is performing I/O actions. In this PR: caching any already performed lookups for a specific distribution (by the dist name).How Has This Been Tested?
✅ CI
✅ Local run on a large Polylith monorepo
Types of changes
Checklist: