Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Footer Link Fix #238

Closed
c0by85 opened this issue Jan 8, 2024 · 2 comments
Closed

Translation Footer Link Fix #238

c0by85 opened this issue Jan 8, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@c0by85
Copy link
Contributor

c0by85 commented Jan 8, 2024

Sorry, but I don't know how I could solve this without countless pull requests. But for every translation the HTML link has to be adapted. Target='_blank' was forgotten. That's why the translation doesn't work.

This must also be changed in the translated text.

Wrong:

"This station is controlled by <a href='https://weewx.com'>WeeWX</a>, an experimental weather software system written in Python."

Correct:

"This station is controlled by <a target='_blank' href='https://weewx.com'>WeeWX</a>, an experimental weather software system written in Python."

image

@c0by85 c0by85 added the bug Something isn't working label Jan 8, 2024
@Daveiano Daveiano added this to the 3.5.0 milestone Jan 9, 2024
@Daveiano
Copy link
Owner

Daveiano commented Jan 9, 2024

Hello there, thanks for reaching out and: no need for apologies! What was wrong with PR #237? Looks good to me.

However, you are right, the target="_blank" is missing in the translation files. I fixed this in cb9df0b, the change will be included in the next release.

@c0by85
Copy link
Contributor Author

c0by85 commented Jan 16, 2024

fixed with cb9df0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants