-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening Webcam Links/Stat Tile links in a Modal #220
Comments
I created a new issue for that, because the discussion in #211 should be solved. So this sounds like kind of a "Kiosk page"? To be clear: You want only the Gauges and Stat tiles to be shown on the page. Without Navigation and Header Bar, right? Should this only be for the main Index page, or all pages? |
HI, No,what I meant was that if you click on a tile the referred page opens in the same area as the gauges and tiles. In that frame.With the Header and navbar still visible. This would be usefull for the tile referrals as well for the webcam / skycam links. Regards, |
Ah ok, I got you!
You mean the links from the sidebar? |
Yes, the links from the sidebar. But now I think of it, if the linked webcam sites of the images in the externals tile would open in that same frame would be als nice ;-) |
Ok, I understand. Another user already had a similar idea, but with a Modal. So the referenced stat tiles pages and/or webcam images are opening in a modal on top of the page. I personally think that's a better solution than replacing the content on the top of the page. What do you think about that approach? |
I had to see what a modal was but that seems as a perfect solution. |
Yeah something like an overlay which sits on top of the page and can be closed easily via a close button/icon, should also work well on a touch screen. I will include this in the next feature release, but I don't know if I will be able to get this out within this year, could be probably finished in the early 2024. |
Hi, I managed to get some time to implement this! I released a pre-release, v3.5.0-alpha1, for you to test this out. Please follow the normal update instructions. You can now set
|
Great, thank you. |
Hi, I tried the alpha version today but the skin will not load. |
Could you provide the relevant section (or the whole file) of your weewx.conf? Also the logs of a full report run would be useful. |
Attached the complete weewx.conf and the log ofa full wee_report run. |
The sylog tells that you are missing the
You should provide the
|
While I understand what you want to do, I think this is out of scope for something the skin could do by itself. There is no reliable way to manipulate a website in frame in that way. What you should do is hide the header and sidebar from your "explanation pages". I assume you created custom template files for your pages. Something like wolkenbasis.html.tmpl? To do this you can simply paste this snippet into your templates (best suited inside the <style>
bx-header {display: none;}
bx-side-nav {display: none;}
main.bx--content {margin-top: 0; margin-left: 0 !important;}
#footer {display: none;} /*This will also hide the footer*/
</style> I hope this solves this? Sorry, I did not get this right until now. |
Sorry for the late reaction but this addition to the templates doe the trick. I have one other puzzle.Ho can I get the skin to be dark at all times? The default is light until you push the button. I would like to be it default dark so it is dark the first time you open it. |
Glad to hear that! Then this will be included in the next release!
Just to be clear: If you switch to dark mode - it should stay in dark mode until you change it again, also if you close and reopen the page (on the same device). Thats also the case for you, right? I guess you want to change the default to dark and also hide the dark/light toggle? Yes, would be great if you could open another issue for that, just describe your needs in that ticket! Thank you very much for all the feedback! |
The clickable tiles work verry well! Thank you for that.
But I have yet another small feature request. Would it be possible to open the destination sites or HTML pages in the main I-frame of the skin in stead of in a full browser window?
I mean the yellow part of the site in attached screenshot.
Again, thank you for your effort and the quick responses.
Regards,
Ed.
Originally posted by @dystechnic in #211 (comment)
The text was updated successfully, but these errors were encountered: