Merge pull request #133 from Datenschule/loud-errors

Fail CI if test_changes errors

README.md

@@ -68,7 +68,7 @@ scrapy crawl <state_name>
 You can deploy the scrapers directly on a server or using Docker. The resulting Docker
 image needs to be run with the `DATABASE_URL` environment variable pointing to a Postgres
 instance. You can for example use docker-compose to achieve this. See the
-[docker-compose file at jedeschule-api](https://github.com/codeforberlin/jedeschule-api/blob/master/docker-compose.yml)
+[docker-compose file at jedeschule-api](https://github.com/codeforberlin/jedeschule-api/blob/main/docker-compose.yml)
 for inspiration.
 
 ## Updating data on jedeschule.codefor.de

test_changes.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -e
+set -euxo pipefail
 
 if [ $CI ]
 then
@@ -11,13 +11,18 @@ fi
 
 echo "Using head reference: ${HEAD_REF}"
 
-CHANGED_SCRAPERS=$(git whatchanged --name-only --pretty="" origin/master..${HEAD_REF}  |
-                  grep spiders |
-                  grep -v helper |
+CHANGED_SCRAPERS=$(git whatchanged --name-only --pretty="" origin/main..${HEAD_REF}  |
+                  grep spiders || true |
+                  grep -v helper || true |
                   sed 's/jedeschule\/spiders\///' |
                   sed 's/\.py//' |
-                  sed 's/_/\-/' |
-                  uniq)
+                  sed 's/_/\-/' | 
+		  uniq)
+
+if [ -z "$CHANGED_SCRAPERS" ]; then
+    echo "No scrapers were changed"
+    exit 0
+fi
 
 for SPIDER in $CHANGED_SCRAPERS
 do