Skip to content

Conversation

mushroomgenie
Copy link

Description

This PR implements quick table search in the active connection on cmd + p / ctrl + p. The changes are made to the ActiveConnectionLayout.tsx file where a new listener is added for the above keyboard shortcut which displays a search bar and on clicking enter on of the results the specific table is displayed.

Type of Change

Please mark the relevant option(s):

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring
  • ⚡ Performance improvement
  • ✅ Test update
  • 🔧 Configuration change

Related Issues

Fixes #103

Screenshots/Recordings

Before

After

QuickTableSearch

Testing

Please confirm the following:

  • I have tested these changes locally
  • I have added/updated tests for these changes (if applicable)
  • All existing tests pass
  • I have tested on different screen sizes (if UI changes)
  • I have tested with different themes (if UI changes)

Test Instructions

Additional Notes

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Copy link
Collaborator

@sathvik-palley sathvik-palley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you think of a better way to implement this feature?

even for this implementation, I tested the search functionality and I see missing tables even when typed the exact name, found the root cause of missing tables - the search feature only loads tables from one database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Quick Table Search (Ctrl + P) with Preview
2 participants