Fix issues in tests (also after accidental commit to the master) #720
Conversation
grzanka
changed the title
There was a problem hiding this comment.
you could assert against e.value.code == 0 according to chatGPT
"Both methods are correct for checking the exit code in a pytest context, but using e.value.code is more direct and semantically clear regarding what you are testing for. It directly reflects your intention to check the exit code. However, it's important to note that in some environments or under certain conditions, the SystemExit exception might not have a code attribute, or it might not be set as expected. In such cases, accessing e.value.args[0] would be a more generic approach that relies on the standard behavior of exceptions in Python.
In conclusion, if you are sure about the consistency of the environment and that the SystemExit exceptions will always have a code attribute correctly set, the first method (e.value.code) is preferable for its clarity and directness. Otherwise, the second method (e.value.args[0]) provides a good fallback and is slightly more generic. It's also worth mentioning that in real-world scenarios, either approach is commonly used and accepted in tests involving pytest and exit codes."
No description provided.