Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1254 Unify output units #702

Merged
merged 6 commits into from
Dec 28, 2023
Merged

1254 Unify output units #702

merged 6 commits into from
Dec 28, 2023

Conversation

hendzeld
Copy link
Contributor

No description provided.

@hendzeld hendzeld self-assigned this Dec 17, 2023
@reviewpad reviewpad bot added the small Pull request is small label Dec 17, 2023
@hendzeld hendzeld mentioned this pull request Dec 17, 2023
7 tasks
@hendzeld hendzeld marked this pull request as ready for review December 21, 2023 17:53
Copy link
Contributor

reviewpad bot commented Dec 21, 2023

AI-Generated Summary: This pull request consists of several patches, it introduces rescaling factor for units and applies it in the code. The method get_unit_for_scoring has been replaced with the method get_unit_and_factor_for_scoring that returns both the unit and the rescaling factor. Multiple units such as doses and energy have been rescaled and the changes are tested and updated in test cases. The pull request also includes some docstring updates for clarity. In the final patch, units for DOSE scoring are rescaled from Gy to MeV/g.

Copy link
Contributor

reviewpad bot commented Dec 21, 2023

AI-Generated Summary: This pull request introduces several changes involving unit rescaling and test updates in the FLUKA reader of the pymchelper code repository. The main body of changes include updates to the scoring unit return functions, incorporating a rescaling factor to adjust the units accordingly. Certain energies expressed in GeV are rescaled to MeV and Dose from GeV/g to MeV/g and Gy. Additionally, a new utilization of this rescaling factor is introduced in the parse_usrbin function.

Additionally, updates were made to the docstring for better clarity and readability. Test files were also updated to reflect the changes introduced in this patch and maintained the current working integrity of the system.

The docstrings of various methods were improved for clarity, the declaration of axes descriptions for binning types was simplified, and the unit for DOSE was also updated. The fluence scoring was rescaled from GeV/cm^3 to MeV/cm^3. In summary, this is a comprehensive improvement and update to the handling of units and scaling within the pymchelper FLUKA reader.

@hendzeld hendzeld merged commit 16565f0 into master Dec 28, 2023
13 checks passed
@hendzeld hendzeld deleted the 1254-unify-output-units branch December 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants