Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection): bug in changing sql flavor #26

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

aarthy-dk
Copy link
Contributor

  • Consolidated the connection form and widget keys to always use the same connection ID, since there is only one connection. Otherwise the form key was changing between "new" and "1" when the SQL flavor was changed, and the form was not keeping the correct state.
  • Updated the Test Connection button to use the data on the next rerun. Otherwise, if the button was clicked immediately after changing a field (without unfocusing the input), the latest change was not used for validating the connection.
  • Disabled the "connection name" field for simplicity since there is only one connection.

@aarthy-dk aarthy-dk requested a review from luis-dk December 2, 2024 22:56
Copy link

github-actions bot commented Dec 2, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
testgen/ui/views/connections
   page.py1691690%1–331
TOTAL8174653617% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 3.576s ⏱️

@luis-dk luis-dk requested a review from str610 December 3, 2024 13:43
@luis-dk luis-dk requested review from str610 and removed request for str610 December 3, 2024 13:43
@aarthy-dk aarthy-dk merged commit 008edc7 into main Dec 3, 2024
3 checks passed
@aarthy-dk aarthy-dk deleted the fix-connection branch December 3, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants