Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to run tests with an Agent 6 pipeline artefacts #1192

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Oct 16, 2024

What does this PR do?

Add the possibility to run tests with an Agent 6 pipeline artefact. I basically add a parameter that will be passed alongside the pipeline_id so we can know where to fetch the artefacts to run the tests

Which scenarios this will impact?

All the scenarios in the Agent 6 branch of the agent repository and the people willing to run tests on Agent 6

Motivation

The version 7 is hardcoded is some places. We'll need to modify this to be able to run the tests on Agent 6 artefacts

Additional Notes

To use it we will also need to do this during the test-infra-definitions bump. We will also need to set the the E2E_MAJOR_VERSION here in the template to 6 on the Agent 6 branch and that should be it.

https://datadoghq.atlassian.net/browse/ADXT-680

@FlorentClarret FlorentClarret changed the title Add the possibility to run tests with an Agent 6 artifact Add the possibility to run tests with an Agent 6 pipeline artefacts Oct 16, 2024
@FlorentClarret FlorentClarret marked this pull request as ready for review October 16, 2024 12:09
@FlorentClarret FlorentClarret requested a review from a team as a code owner October 16, 2024 12:09
common/config/environment.go Outdated Show resolved Hide resolved
components/datadog/agent/host_linuxos.go Outdated Show resolved Hide resolved
components/datadog/agent/host_linuxos.go Outdated Show resolved Hide resolved
components/datadog/agent/host_linuxos.go Outdated Show resolved Hide resolved
components/datadog/agent/host_windowsos.go Outdated Show resolved Hide resolved
components/datadog/agentparams/params.go Show resolved Hide resolved
components/datadog/agentparams/params.go Show resolved Hide resolved
FlorentClarret and others added 3 commits October 16, 2024 15:39
Co-authored-by: Kevin Fairise <132568982+KevinFairise2@users.noreply.github.com>
Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @FlorentClarret , and great review to @KevinFairise2

components/datadog/agent/host_linuxos.go Outdated Show resolved Hide resolved
Co-authored-by: Kevin Fairise <132568982+KevinFairise2@users.noreply.github.com>
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 17, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Oct 17, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 20m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit fdf894e into main Oct 17, 2024
9 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/agent6 branch October 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants