Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ASM attacker fingerprinting capabilities #3061

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

CarlesDD
Copy link
Contributor

@CarlesDD CarlesDD commented Sep 18, 2024

Motivation

Test new capabilities for ASM attacker fingerprinting are sent.

Changes

  • Individual test for each new capability.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

APPSEC-54718

@CarlesDD CarlesDD force-pushed the ccapell/attacker-fingerprinting-capabilities branch from b35780c to e9eecc7 Compare September 18, 2024 11:51
@CarlesDD CarlesDD marked this pull request as ready for review September 18, 2024 11:53
@CarlesDD CarlesDD requested review from a team as code owners September 18, 2024 11:53
@CarlesDD CarlesDD requested review from lievan, mabdinur, manuel-alvarez-alvarez and ValentinZakharov and removed request for a team September 18, 2024 11:53
@simon-id
Copy link
Member

simon-id commented Sep 19, 2024

Are those capabilities supposed to be added at all time, or only when WAF rules update is available ?
Resolved: Only when the RC rules update is on!

@CarlesDD CarlesDD merged commit 6da2a4a into main Sep 23, 2024
372 of 386 checks passed
@CarlesDD CarlesDD deleted the ccapell/attacker-fingerprinting-capabilities branch September 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants