Set typescrit+sqlinjection bug as fixed #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-id
reviewed
Jan 29, 2024
| @@ -22,7 +22,7 @@ class TestSqlInjection(BaseSinkTest): | |||
| "python": {"flask-poc": "app.py", "django-poc": "app/urls.py"}, | |||
| } | |||
|
|
|||
| @bug(weblog_variant="express4-typescript", reason="Incorrect vulnerability location") | |||
| @bug(context.library < "nodejs@5.2.1", weblog_variant="express4-typescript", reason="Incorrect vulnerability location") | |||
There was a problem hiding this comment.
we very rarely release patch versions, it's probably going to be 5.3.0
3 tasks
uurien
force-pushed
the
ugaitz/nodejs-sqli-location-fixed
branch
from
0121bb8
to
2efbdb0
Compare
uurien
force-pushed
the
ugaitz/nodejs-sqli-location-fixed
branch
3 times, most recently
from
edccbb2
to
f23bf65
Compare
simon-id
approved these changes
Jan 30, 2024
uurien
force-pushed
the
ugaitz/nodejs-sqli-location-fixed
branch
from
f23bf65
to
0ac0aa4
Compare
cbeauchesne
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bug fixed and merged in master, remove
XPASSfrom testsChanges
Set bug fix version
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presentsbuild-XXX-imagelabel is presentFailing tests are cpp and java tests, are not related with this PR