Add log-collapsing sketches #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimtown
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Thanks for submitting this! The code looks good, just one request and one question:
-
The
yarn.lockchange looks unrelated (and appears to just be formatting) - can we back that out? I'm guessing it was from annpm install: [BUG]npm installmodifies yarn.lock in incorrect ways npm/cli#5126 -
(Optional) Do you think it's worth documenting these new options in the README? Can even just be a single heading/paragraph showing how to import (and that setting
binLimitis possible).
Will re-review after 1)
Qard
force-pushed
the
add-log-collapsing-sketches
branch
from
9d8c63c
to
1956970
Compare
|
Ah, yep. Missed the No particular opinion on documenting the new interfaces. I can add some docs for that if you like. |
brimtown
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the necessary stores were there, but there was no interface in the public API to make a
LogCollapsingHighestDenseDDSketchorLogCollapsingLowestDenseDDSketch. This adds those and just reuses the existing tests for DDSketch.