-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the default value of addExtension to true #233
Conversation
addextension
to trueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, let's do a major version bump of the plugin (e.g. 4.0) since this is a breaking change.
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 76.51% 76.39% -0.12%
==========================================
Files 19 19
Lines 894 894
Branches 215 215
==========================================
- Hits 684 683 -1
- Misses 181 182 +1
Partials 29 29
Continue to review full report at Codecov.
|
What does this PR do?
Enables the extension by default. Sets
addExtension
env var totrue
.Motivation
To move towards using the extension for AWS Lambda, rather than the forwarder.
Testing Guidelines
Unit and Integration testing
Additional Notes
Types of changes
Check all that apply