Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default value of addExtension to true #233

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

jcstorms1
Copy link
Contributor

@jcstorms1 jcstorms1 commented Mar 2, 2022

What does this PR do?

Enables the extension by default. Sets addExtension env var to true.

Motivation

To move towards using the extension for AWS Lambda, rather than the forwarder.

Testing Guidelines

Unit and Integration testing

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@jcstorms1 jcstorms1 requested review from a team as code owners March 2, 2022 21:37
@jcstorms1 jcstorms1 changed the title Set the default value of addextension to true Set the default value of addExtension to true Mar 2, 2022
Copy link
Contributor

@IvanTopolcic IvanTopolcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@nhinsch nhinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, let's do a major version bump of the plugin (e.g. 4.0) since this is a breaking change.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #233 (6b44ddb) into master (eac2507) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   76.51%   76.39%   -0.12%     
==========================================
  Files          19       19              
  Lines         894      894              
  Branches      215      215              
==========================================
- Hits          684      683       -1     
- Misses        181      182       +1     
  Partials       29       29              
Impacted Files Coverage Δ
src/env.ts 93.25% <ø> (ø)
src/index.ts 69.93% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac2507...6b44ddb. Read the comment docs.

@jcstorms1 jcstorms1 merged commit 1582f54 into master Mar 3, 2022
@jcstorms1 jcstorms1 deleted the storms/change-addextension-default branch March 3, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants