Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-5090] Add protocol property #226

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Oct 24, 2024

see RUM-5090

@RomanGaignault RomanGaignault requested review from a team as code owners October 24, 2024 10:27
@RomanGaignault RomanGaignault changed the title add new protocol property [RUM-5090] Add protocol property Oct 24, 2024
0xnm
0xnm previously approved these changes Oct 24, 2024
BenoitZugmeyer
BenoitZugmeyer previously approved these changes Oct 24, 2024
cy-moi
cy-moi previously approved these changes Oct 24, 2024
Copy link
Contributor

@cy-moi cy-moi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nit: It could be nice to add this field in samples as well.

@RomanGaignault RomanGaignault dismissed stale reviews from cy-moi, BenoitZugmeyer, and 0xnm via 8a682d9 October 24, 2024 12:22
@RomanGaignault RomanGaignault merged commit e1c6dde into master Oct 24, 2024
8 checks passed
@RomanGaignault RomanGaignault deleted the romanG/add-new-protocol-property branch October 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants