Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default shell on system #135

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

kumiDa
Copy link
Contributor

@kumiDa kumiDa commented Apr 29, 2021

Update the initialization to accept the default shell set in the system, if that's not found to fall back to /bin/bash

@kumiDa kumiDa requested a review from a team as a code owner April 29, 2021 16:31
jd
jd previously approved these changes Apr 29, 2021
brettlangdon
brettlangdon previously approved these changes Apr 29, 2021
@brettlangdon
Copy link
Member

@rahul-kumi thanks for the contribution, the only failing check is for adding a changelog entry.

We use reno to manage release notes.

Once you have it installed you can run reno new <slug>

Or we have a command in our riotfile.py for riot for reno, you can run riot run -s reno new <slug>.

@kumiDa kumiDa dismissed stale reviews from brettlangdon and jd via 5188640 April 29, 2021 17:17
@mergify mergify bot merged commit a32107f into DataDog:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants